Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar different size - is it useful? #3854

Closed
RussKie opened this issue Jul 15, 2017 · 4 comments
Closed

Avatar different size - is it useful? #3854

RussKie opened this issue Jul 15, 2017 · 4 comments
Labels
type: discussion

Comments

@RussKie
Copy link
Member

RussKie commented Jul 15, 2017 •
edited

Going through the code I found that there is a whole avatar context menu and it is possible to change the avatar size...

image

I am genuinely curious - does anyone use non-default avatar size?
I like avatar feature, but I couldn't think of a reason why I would want someone else's avatar take valuable space on my screen...

The reason I ask - I am tinkering with possible UI uplift of the commit details panel and the avatar size functionality is something I would deprecate and remove.
@EbenZhang
Copy link
Contributor

EbenZhang commented Jul 15, 2017 •
edited

FYI: I'm using the default size and never changed the image size. It's not useful to me.

@pmiossec
Copy link
Member

I don't find it useful, too.
Perhaps to reduce the size it would have been useful by the proposed sized are only to display it too big...

@jrfnl
Copy link

jrfnl commented Jul 19, 2017

Same here. I use the default small size and never felt the need for the avatar to be bigger than that.

@RussKie
Copy link
Member Author

RussKie commented Jul 19, 2017

Thank you for the feedback.

@RussKie RussKie mentioned this issue Jul 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pmiossec @EbenZhang @jrfnl @jbialobr @RussKie